Skip to content

Fix #4345: issues with dependent methods #4346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2018

Conversation

smarter
Copy link
Member

@smarter smarter commented Apr 19, 2018

No description provided.

This generalizes TypeLambda#instantiateBounds to all LambdaTypes.
@smarter
Copy link
Member Author

smarter commented Apr 19, 2018

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

@smarter smarter requested a review from odersky April 19, 2018 19:36
smarter added 3 commits April 19, 2018 21:49
The raw paramInfoss of a method type contain parameter references that
should be instantiated before using the type anywhere.
The paramInfos of a MethodType may contain TermParamRefs, when creating
symbols for these parameters, the TermParamRefs need to be replaced by
TermRef to previously created parameter symbols.
@smarter smarter force-pushed the fix/termparamref-subtyping branch from 5422ac2 to 97f9026 Compare April 19, 2018 19:49
@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/4346/ to see the changes.

Benchmarks is based on merging with master (ae816fb)

Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Yes, polyDefDef did not handle parameter dependencies so far.

@odersky odersky merged commit 428b5ea into scala:master Apr 20, 2018
@allanrenucci allanrenucci deleted the fix/termparamref-subtyping branch April 20, 2018 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants